Update CommercePosTransactionBaseActions.php #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurg
commented
Feb 21, 2017
yurg
commented
Have faced this one https://www.drupal.org/node/2824865 It's closed as "Works as designed", yet still affects operations at our side, because taxes are being added twice in certain circumstances. It seems, commenting out commerce_tax_calculate_by_type fixes issue in our case, yet it's not quite clear if there are any side effects, caused by code change. We observe no issues so far, doesn't mean there aren't any. It seems the piece of code may be obsolete, yet not 100% sure.
|
@yurg I just implemented checked the issue on DO and applied your fix. There is an issue though, although it might not matter to you. What I've found so far is that you won't get a breakdown of prices in the total column. With your fix: Without fix: So just keep us informed if you run into any other issues with it. We're still not sure if it's a commerce issue or a POS issue. |
Author
|
@thejacer87 Thank you for note; we're aware of prices breakdown disappearance, it's an acceptable trade-off, since we don't need it for a moment. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.